- dev - passt

[PATCH 0/2] Address warnings from gcc 12.2 with -flto
by Stefano Brivio 28 Sep '22

28 Sep '22

The first one is a bogus report of an uninitialised field passed as input to hash functions for TCP connections, already seen with gcc 11. The second one is a bogus stringop-overread which already happened with gcc 12.1, but this time a "cute" pragma won't make it go away. Both harmless, but noisy. Based on pending series posted by David, if it matters. Stefano Brivio (2): Makefile: Extend noinline workarounds for LTO and -O2 to gcc 12 udp: Replace pragma to ignore bogus stringop-overread warning with workaround Makefile | 6 +++--- udp.c | 26 ++++++++++++++++++-------- util.h | 23 ----------------------- 3 files changed, 21 insertions(+), 34 deletions(-) -- 2.35.1

1 2

[PATCH v2 00/11] Assorted test fixes, batch 7
by David Gibson 26 Sep '22

26 Sep '22

Here's another bundle of test fixes, focused on making the tests faster and more reliable. Based on my earlier series cleaning up the port forwarding data structures. Changes since v1: * Rebased and fixed conflict with another Makefile change * Dropped patch removing sleeps from layout functions David Gibson (11): test: Add wait_for() shell helper test: Remove unnecessary sleeps from shutdown tests test: More robust wait for pasta/passt to be ready test: Use --config-net for namespace setup test: Simplify data handling for transfer tests test: Remove unneccessary pane naming from layout_two_guests clang-tidy: Disable 'readability-identifier-length' cppcheck: Avoid excessive scanning due to system headers cppcheck: Run quietly Makefile: Simplify getting target triple for compiler cppcheck: Add target specific headers Makefile | 33 +++---- test/.gitignore | 1 + test/Makefile | 15 ++- test/lib/context | 4 +- test/lib/layout | 4 - test/lib/setup | 32 +++---- test/lib/util | 8 ++ test/passt.mbuto | 6 +- test/passt/shutdown | 1 - test/passt/tcp | 53 +++++------ test/passt/udp | 29 +++--- test/passt_in_ns/shutdown | 1 - test/passt_in_ns/tcp | 187 ++++++++++++++++---------------------- test/passt_in_ns/udp | 93 ++++++++----------- test/pasta/tcp | 79 +++++++--------- test/pasta/udp | 43 ++++----- test/two_guests/basic | 2 +- 17 files changed, 251 insertions(+), 340 deletions(-) -- 2.37.3

1 11

[PATCH v2 0/8] Clean up and fix bugs in port forwarding data structures
by David Gibson 24 Sep '22

24 Sep '22

The information we need to keep track of which ports are forwarded where is currently split across several different values and data structures in several different places. Worse, a number of those structures are incorrectly sized due to an off by one error, which could lead to buffer overruns. Fix the sizing, and re-organize the data structures in a way that should make it less likely to repeat that mistake. While we're there, correct a similar off-by-one mis-sizing of a number of other arrays. Changes since v1: * Use a define for the array size, rather than a typedef to handle the bitmaps of ports David Gibson (8): Improve types and names for port forwarding configuration Consolidate port forwarding configuration into a common structure udp: Delay initialization of UDP reversed port mapping table Don't use indirect remap functions for conf_ports() Pass entire port forwarding configuration substructure to conf_ports() Treat port numbers as unsigned Fix widespread off-by-one error dealing with port numbers icmp: Correct off by one errors dealing with number of echo request ids Makefile | 2 +- conf.c | 136 +++++++++++++++++++++++---------------------------- icmp.c | 5 +- passt.h | 1 + port_fwd.h | 34 +++++++++++++ tcp.c | 68 ++++++++------------------ tcp.h | 13 ++--- tcp_splice.c | 4 +- udp.c | 59 ++++++++++------------ udp.h | 27 +++++----- 10 files changed, 168 insertions(+), 181 deletions(-) create mode 100644 port_fwd.h -- 2.37.3

2 10

[PATCH] Fix the name of the qemu-system-* executable
by Dario Faggioli 24 Sep '22

24 Sep '22

Hello everyone! So, while playing with out passt package for openSUSE, my colleague Vasiliy found out an issue in how passt assumes the qemu binary to be called. In fact, in openSUSE, while we have a package that allows people to launch qemu by invoking `qemu-kvm`, we don't install it by default, and we therefore only have the standard upstream names in the filesystem, which have the ARCH part in lowercase. This patch, which we're currently carrying as a downstream one in our package, should fix the problem. Thanks and Regards, Dario --- Vasiliy Ulyanov (1): Fix the name of the qemu-system-* executable Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)

2 3

[PATCH 0/8] Clean up and fix bugs in port forwarding data structures
by David Gibson 24 Sep '22

24 Sep '22

The information we need to keep track of which ports are forwarded where is currently split across several different values and data structures in several different places. Worse, a number of those structures are incorrectly sized due to an off by one error, which could lead to buffer overruns. Fix the sizing, and re-organize the data structures in a way that should make it less likely to repeat that mistake. While we're there, correct a similar off-by-one mis-sizing of a number of other arrays. David Gibson (8): Improve types and names for port forwarding configuration Consolidate port forwarding configuration into a common structure udp: Delay initialization of UDP reversed port mapping table Don't use indirect remap functions for conf_ports() Pass entire port forwarding configuration substructure to conf_ports() Treat port numbers as unsigned Fix widespread off-by-one error dealing with port numbers icmp: Correct off by one errors dealing with number of echo request ids Makefile | 2 +- conf.c | 136 +++++++++++++++++++++++---------------------------- icmp.c | 5 +- passt.h | 1 + port_fwd.h | 34 +++++++++++++ tcp.c | 68 ++++++++------------------ tcp.h | 13 ++--- tcp_splice.c | 4 +- udp.c | 59 ++++++++++------------ udp.h | 27 +++++----- 10 files changed, 168 insertions(+), 181 deletions(-) create mode 100644 port_fwd.h -- 2.37.3

2 12

[PATCH 00/12] Assorted test fixes, batch 7
by David Gibson 24 Sep '22

24 Sep '22

Here's another bundle of test fixes, focused on making the tests faster and more reliable. Based on my earlier series cleaning up the port forwarding data structures. David Gibson (12): test: Add wait_for() shell helper test: Remove unnecessary sleeps from layout functions test: Remove unnecessary sleeps from shutdown tests test: More robust wait for pasta/passt to be ready test: Use --config-net for namespace setup test: Simplify data handling for transfer tests test: Remove unneccessary pane naming from layout_two_guests clang-tidy: Disable 'readability-identifier-length' cppcheck: Avoid excessive scanning due to system headers cppcheck: Run quietly Makefile: Simplify getting target triple for compiler cppcheck: Add target specific headers Makefile | 32 +++---- test/.gitignore | 1 + test/Makefile | 15 ++- test/lib/context | 4 +- test/lib/layout | 24 ----- test/lib/setup | 32 +++---- test/lib/util | 8 ++ test/passt.mbuto | 6 +- test/passt/shutdown | 1 - test/passt/tcp | 53 +++++------ test/passt/udp | 29 +++--- test/passt_in_ns/shutdown | 1 - test/passt_in_ns/tcp | 187 ++++++++++++++++---------------------- test/passt_in_ns/udp | 93 ++++++++----------- test/pasta/tcp | 79 +++++++--------- test/pasta/udp | 43 ++++----- test/two_guests/basic | 2 +- 17 files changed, 250 insertions(+), 360 deletions(-) -- 2.37.3

2 21

[PATCH 00/11] Fixes for demos, pre-push hook, README
by Stefano Brivio 24 Sep '22

24 Sep '22

After the recent rework of command dispatch and handling of temporary files, a few issues prevent demos from completing, and CI files from being uploaded. Fix those. On top of that, rebase to Podman's latest upstream so that the Podman demo can run again, shorten paths used to change directories in demo scripts, and fix a number of inconsistencies in the README. Given that the current state of the website is inconsistent, I'd be inclined to apply these right away, while posting to ease later review anyway. Stefano Brivio (11): contrib/podman: Rebase to latest upstream hooks/pre_push: Fix upload of CI's logs and terminal capture file test/demo: Use relative paths to change directories when possible test/demo: Avoid using port 5201 on the host test/lib: Drop perf_report_append() from perf_report test/lib: Don't try to write to perf.js when running demos README: Fix misspellings of openSUSE README: Point openSUSE links to Dario's OBS repository README: Fix indentation in "Try It" section README: Fix paragraph in Try It section of passt README: Add legend for Features section README.md | 24 ++- ...001-libpod-Add-pasta-networking-mode.patch | 95 +++++----- hooks/pre-push | 11 +- test/demo/passt | 45 +++-- test/demo/pasta | 20 +- test/demo/podman | 176 +++++++++--------- test/lib/perf_report | 13 +- 7 files changed, 198 insertions(+), 186 deletions(-) -- 2.35.1

1 11

[PATCH] test/passt.mbuto: Don't fail on missing guest public key
by Stefano Brivio 23 Sep '22

23 Sep '22

We won't necessarily run mbuto as part of regular tests: it can also be used for demos or out-of-tree tests. To keep the profile simple, leave the whole sshd setup there, which is otherwise harmless, but don't fail if guest-key.pub is missing in the current directory. Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> --- test/passt.mbuto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/passt.mbuto b/test/passt.mbuto index d29f456..51c9ada 100755 --- a/test/passt.mbuto +++ b/test/passt.mbuto @@ -68,7 +68,7 @@ EOF ln -s /run/sshd /usr/share/empty.sshd cat > /root/.ssh/authorized_keys <<EOF -'"$(cat guest-key.pub)"' +'"$(cat guest-key.pub 2>/dev/null || :)"' EOF chmod 600 /root/.ssh/authorized_keys chmod 700 /root -- 2.35.1

1 0

[PATCH 0/7] Fixes and workarounds for tests, Coverity warnings
by Stefano Brivio 23 Sep '22

23 Sep '22

With this series, I'm almost able to run the full test suite together with the new command dispatch mechanism. I still hit frequent failures in the passt_tcp performance test, so I'm not pushing this out at the moment, but as it's taking me a while, I'd rather share this earlier. Included are also two fixes for harmless (but ugly) issues discovered by Coverity. Stefano Brivio (7): test/perf: Always use /sbin/sysctl in tcp test test/perf: Switch performance test duration to 10 seconds instead of 30 tap: Check return value of accept4() before calling getsockopt() conf, tcp, udp: Arrays for ports need 2^16 values, not 2^16-8 test/lib: Restore IFS while executing directives in def blocks test/lib: Wait on iperf3 clients to be done, then send SIGINT to servers test/perf: Disable periodic throughput reports to avoid vhost hang conf.c | 2 +- tap.c | 6 ++++-- tcp.h | 4 ++-- test/lib/test | 20 ++++++++++---------- test/perf/passt_tcp | 10 +++++----- test/perf/passt_udp | 4 ++-- test/perf/pasta_tcp | 10 +++++----- test/perf/pasta_udp | 4 ++-- udp.h | 4 ++-- 9 files changed, 33 insertions(+), 31 deletions(-) -- 2.35.1

2 18

[PATCH 0/5] Some more hacks and workarounds to make tests pass again
by Stefano Brivio 23 Sep '22

23 Sep '22

Some of these are actual fixes, some are just hacks to keep tests running while we figure out issues. A part of this series should actually be reverted once we figure out why iperf3 clients and servers get stuck now and then. Stefano Brivio (5): test/lib: Run also iperf3 clients in background, revert to time-based wait test/lib: Wait for kernel to free up ports used by iperf3 before reusing them test/perf: Wait for neper servers in guest to be ready before starting client test/lib: Wait for DHCPv4 before starting DHCPv6 client in two_guests test test/distro: Update workarounds for Ubuntu 22.04 on s390x test/distro/ubuntu | 4 +++- test/lib/setup | 1 + test/lib/test | 11 ++++++++--- test/perf/passt_tcp | 4 ++++ test/perf/passt_udp | 2 ++ 5 files changed, 18 insertions(+), 4 deletions(-) -- 2.35.1

2 6