September 2026 - dev

Fix for Bug #221 -- Issue concerning bigger routing tables
by Martin Schitter 08 Sep '26

08 Sep '26

This is a rebased version of the three patches to fix #221. Only patch 3/3 got slightly modified becaus of merge conflicts. [PATCH 1/3] Fix handling of netlink multipart route dumps. [PATCH 2/3] Timekeeping: Resolving Route Dependencies [PATCH 3/3] Optimize route dependency solver.

1 2

[PATCH] contrib/apparmor: add missing setfcap capability
by Sevinj Aghayeva 08 Sep '26

08 Sep '26

Since Linux 5.12, writing a mapping from UID 0 to /proc/self/uid_map requires CAP_SETFCAP. isolation.c already retains this capability for the case where pasta spawns a child from a non-init user namespace, but the AppArmor profile doesn't grant it, so the write is denied whenever the profile is enforced. Add setfcap to the AppArmor abstraction to match what isolation.c expects. Link: https://bugs.passt.top/show_bug.cgi?id=172 Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva(a)gmail.com> --- contrib/apparmor/abstractions/passt | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/apparmor/abstractions/passt b/contrib/apparmor/abstractions/passt index 85bd1ee..f4570c1 100644 --- a/contrib/apparmor/abstractions/passt +++ b/contrib/apparmor/abstractions/passt @@ -24,6 +24,7 @@ capability setpcap, capability net_admin, capability sys_ptrace, + capability setfcap, userns, / r, # isolate_prefork(), isolation.c -- 2.43.0

2 1

[PATCH] vhost_user: Reset vq enable flag in vu_cleanup()
by Laurent Vivier 08 Sep '26

08 Sep '26

vu_cleanup() resets most virtqueue state (started, notification, file descriptors) but does not reset the enable flag. After a QEMU disconnect and reconnect, the stale enable flag causes vu_set_vring_enable_exec() to hit its early return check (vq->enable == enable). Reset vq->enable to false in vu_cleanup() alongside the other virtqueue state. Signed-off-by: Laurent Vivier <lvivier(a)redhat.com> Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au> --- vhost_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vhost_user.c b/vhost_user.c index a1259c2624c0..272295f29db4 100644 --- a/vhost_user.c +++ b/vhost_user.c @@ -1081,6 +1081,7 @@ void vu_cleanup(struct vu_dev *vdev) struct vu_virtq *vq = &vdev->vq[i]; vq->started = false; + vq->enable = false; vq->notification = true; if (vq->call_fd != -1) { -- 2.55.0

2 1

[PATCH 0/5] Settings for Zed editor and minor fixups
by David Gibson 08 Sep '26

08 Sep '26

I've been playing with the Zed editor again. It's default settings don't quite match passt's style, so add a config file to make it do the right thing. Also update some of the config for clangd to suppress bogus warnings the way Zed invokes it. Between them these also found a handful of minor but real code warts, so fix those, too. David Gibson (5): clangd: Add _GNU_SOURCE to default clangd options util: Eliminate a stray trailing whitespace util: Add missing O_CLOEXEC for !HAS_GETRANDOM path util, pasta: Remove some unneeded #includes Add Zed editor settings .clangd | 2 +- .zed/settings.json | 4 ++++ pasta.c | 1 - util.c | 7 ++----- 4 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 .zed/settings.json -- 2.53.0

3 6

[PATCH] udp_flow: Remove obsolete comment
by David Gibson 08 Sep '26

08 Sep '26

This comment was true - although the upshot was not particularly clear - when it was introduced. However, for other reaosns we now *do* always populate ini->oaddr from flow_initiate_sa(). So rather than explaning why we can't, we can actually validate ini->oaddr. Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- udp_flow.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/udp_flow.c b/udp_flow.c index f59649f6..a29f3562 100644 --- a/udp_flow.c +++ b/udp_flow.c @@ -247,11 +247,8 @@ flow_sidx_t udp_flow_from_sock(const struct ctx *c, uint8_t pif, ini = flow_initiate_sa(flow, pif, s_in, dst, port); if (!inany_is_unicast(&ini->eaddr) || + inany_is_unspecified(&ini->oaddr) || ini->eport == 0 || ini->oport == 0) { - /* In principle ini->oddr also must be specified, but when we've - * been initiated from a socket bound to 0.0.0.0 or ::, we don't - * know our address, so we have to leave it unpopulated. - */ flow_err_ratelimit(flow, now, "Invalid endpoint on UDP recvfrom()"); flow_alloc_cancel(flow); -- 2.55.0

2 1

[PATCH 0/1] Leftover parsing patch
by David Gibson 08 Sep '26

08 Sep '26

I'm not sure if this patch is particularly useful, however it was already complete, left over from the earlier parsing rework. So, I thought I might as well post it in case it's interesting. David Gibson (1): parse: Convert parse_mac() to conventions of parse.c Makefile | 1 + conf.c | 43 ++++++++----------------------------------- parse.c | 30 ++++++++++++++++++++++++++++++ parse.h | 1 + 4 files changed, 40 insertions(+), 35 deletions(-) -- 2.55.0

2 2

[PATCH] netlink: Don't warn about multiple interfaces when there's only one
by Hayato Kiwata 01 Sep '26

01 Sep '26

Suppose there is a single network interface on the host, with two addresses of different prefixes assigned to it. In this situation, running pasta to create an isolated netns prints "Multiple interfaces with %s routes, picked first", even though there is in fact only one candidate interface. Reproducer: sudo ip link add dummy42 type dummy sudo ip link set dev dummy42 up sudo ip addr add fdaa:aaaa:aaaa::1/64 dev dummy42 sudo ip addr add fdbb:bbbb:bbbb::1/64 dev dummy42 pasta --config-net -- true This message is meant to indicate that there are multiple candidate interfaces, but in fact there is only one, which can mislead users. Therefore, avoid printing this message when there are multiple non-default routes that all belong to the same interface. Fixes: 450a6131beab ("netlink: With no default route, pick the first interface with a route") Signed-off-by: Hayato Kiwata <dev(a)haytok.jp> --- netlink.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/netlink.c b/netlink.c index 8d20dbb..225b666 100644 --- a/netlink.c +++ b/netlink.c @@ -271,6 +271,7 @@ unsigned int nl_get_ext_if(int s, sa_family_t af) }; unsigned defifi = 0, anyifi = 0; unsigned ndef = 0, nany = 0; + bool multi_anyif = false; struct nlmsghdr *nh; struct rtattr *rta; char buf[NLBUFSIZ]; @@ -330,6 +331,8 @@ unsigned int nl_get_ext_if(int s, sa_family_t af) nany++; if (!anyifi) anyifi = thisifi; + else if (anyifi != thisifi) + multi_anyif = true; } } @@ -345,7 +348,7 @@ unsigned int nl_get_ext_if(int s, sa_family_t af) } if (anyifi) { - if (nany > 1) { + if (multi_anyif) { info("Multiple interfaces with %s routes, picked first", af_name(af)); } -- 2.39.5 (Apple Git-154)

2 1