Re: [PATCH 02/12] conf: Use parameter instead of global in conf_nat()

On Wed, Jul 01, 2026 at 02:07:06AM +0200, Stefano Brivio wrote:

On Fri, 26 Jun 2026 17:09:53 +1000 David Gibson wrote:

...

Conf nat takes a parameter @arg for the argument it's parsing. However on

Nit: conf_nat().

Huh. What a weird mistake to make. Oh well, fixed.

...

error we print instead optarg, the getopt() global. This happens to be the same thing at the time of the call, but it's not the right way to get to it.

Signed-off-by: David Gibson --- conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf.c b/conf.c index 4755a9f4..6ab8efec 100644 --- a/conf.c +++ b/conf.c @@ -1049,7 +1049,7 @@ static void conf_nat(const char *arg, struct in_addr *addr4, !IN4_IS_ADDR_MULTICAST(addr4)) return;

- die("Invalid address to remap to host: %s", optarg); + die("Invalid address to remap to host: %s", arg); }

/**

-- Stefano

-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson