Re: [PATCH v9 10/23] pesto, conf: Have pesto connect to passt and check versions

On Wed, 6 May 2026 12:57:21 +0200 Laurent Vivier wrote:

On 5/6/26 11:22, Stefano Brivio wrote:

...

From: David Gibson

Start implementing pesto in earnest. Create a control/configuration socket in passt. Have pesto connect to it and retrieve a server greeting Perform some basic version checking.

Signed-off-by: David Gibson [sbrivio: Avoid potential recursive calling between conf_accept() and conf_close(), reported by clang-tidy] [sbrivio: In conf(), check we're not exceeding sizeof(c->control_path) instead of sizeof(c->socket_path), and, in pesto's main(), print argv[optind] instead of argv[1] to indicate an invalid socket path, both reported by Jon Maloy] [sbrivio: In pesto's main(), drop unnecessary newline from error message, reported by Laurent] [sbrivio: Don't use SOCK_NONBLOCK on accept4(), as that only applies to the *new* file descriptor, which we don't want -- set O_NONBLOCK on the listening file descriptor using fcntl()] [sbrivio: Switch to protocol version 1, and reflect the true magic behind pesto, i.e. basil, into the magic string]

But the real value is in pine nuts (110 €/kg here).

Wow, I hadn't realised. They seem to be half that price here, but still:

(I make mine with bear's garlic and almonds)

...yeah, we should definitely aim at compatibility. -- Stefano