Re: [PATCH v7 2/7] dhcp: Add option configuration tracking with enum opt_conf

On Thu, 1 Oct 2026 18:45:55 +0530 Anshu Kumari wrote:

@@ -243,6 +256,7 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len) int i;

opts[119].slen = 0; + opts[119].conf = OPT_DEFAULT;

I think that at this point, instead of doing this...

for (i = 0; i < 255; i++) max_len -= opts[i].slen; @@ -291,7 +305,7 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len) }

if (!opts[119].slen) - opts[119].slen = -1; + opts[119].conf = OPT_UNSET;

...it would make more sense to simply set opts[119].conf here, that is: if (opts[119].slen) opts[119].conf = OPT_DEFAULT; -- Stefano