Re: [PATCH v6 06/18] pif: Limit pif names to 128 bytes

5 May 2026

On Mon, 4 May 2026 11:12:16 +0200
Laurent Vivier  wrote:
...
On 5/3/26 23:55, Stefano Brivio wrote:
...
From: David Gibson 
All current pif names are quite short, and we expect them to remain short
when/if we allow arbitrary pifs.  However, because of the structure of
the current code we don't enforce any limit on the length.
This will become more important with dynamic configuration updates, so
start enforcing a length limit.  Specifically we allow pif names to be up
to 128 bytes (PIF_NAME_SIZE), including the terminating \0.  This is
more or less arbitrary, but seems like it should be comfortably enough for
all the cases we have in mind.
Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio 
Reviewed-by: Laurent Vivier 
There is a little typo below
...
---
  pif.c | 2 +-
  pif.h | 5 ++++-
  2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/pif.c b/pif.c
index 1e80724..d5e3161 100644
--- a/pif.c
+++ b/pif.c
@@ -17,7 +17,7 @@
  #include "inany.h"
  #include "epoll_ctl.h"
-const char *pif_type_str[] = {
+const char pif_type_str[][PIF_NAME_SIZE] = {
  [PIF_NONE]		= "<none>",
  [PIF_HOST]		= "HOST",
  [PIF_TAP]		= "TAP",
diff --git a/pif.h b/pif.h
index 7bb58e5..90dd3a3 100644
--- a/pif.h
+++ b/pif.h
@@ -35,7 +35,9 @@ enum pif_type {
  PIF_NUM_TYPES,
  };
-extern const char *pif_type_str[];
+/* Maxmimum size of a pif name, including \0 */
"Maximum"
Fixed in v7.

-- 
Stefano

    