clang-tidy 23.1.5 reports:
passt-repair.c:122:6: error: redundant parentheses around expression
[readability-redundant-parentheses,-warnings-as-errors]
122 | if ((stat(a->sun_path, sb))) {
and the same for the stat() call in main(). There's no assignment in
those conditions, so the extra parentheses are pointless. Drop them.
Signed-off-by: Jon Maloy
---
passt-repair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/passt-repair.c b/passt-repair.c
index 3958c3af..2a147432 100644
--- a/passt-repair.c
+++ b/passt-repair.c
@@ -119,7 +119,7 @@ static int wait_for_socket(struct sockaddr_un *a, const char *dir,
ret = snprintf(a->sun_path, sizeof(a->sun_path), "%s/%s",
dir, ev->name);
- if ((stat(a->sun_path, sb))) {
+ if (stat(a->sun_path, sb)) {
FPRINTF(stderr, "Can't stat() %s: %i\n", a->sun_path, errno);
_exit(1);
}
@@ -186,7 +186,7 @@ int main(int argc, char **argv)
_exit(1);
}
- if ((stat(argv[1], &sb))) {
+ if (stat(argv[1], &sb)) {
FPRINTF(stderr, "Can't stat() %s: %i\n", argv[1], errno);
_exit(1);
}
--
2.56.1