Re: [PATCH v4 3/4] dhcp: Add --dhcp-opt with option table and value parser

1 Jul 2026


      On Wed, 17 Jun 2026 18:52:37 +0530
Anshu Kumari  wrote:
...
[...]
@@ -182,6 +182,8 @@ struct ip6_ctx {
  * @dns_search:		DNS search list
  * @hostname:		Guest hostname
  * @fqdn:		Guest FQDN
+ * @dhcp_opts:		User-specified DHCP options from --dhcp-opt
+ * @dhcp_opts.str:	String value from command line
  * @ifi6:		Template interface for IPv6, -1: none, 0: IPv6 disabled
  * @ip6:		IPv6 configuration
  * @pasta_ifn:		Name of namespace interface for pasta
@@ -264,6 +266,10 @@ struct ctx {
  char hostname[PASST_MAXDNAME];
  char fqdn[PASST_MAXDNAME];
+	struct {
+		char str[255];
+	} dhcp_opts[256];
This just occurred to me after reviewing the DHCPv6 equivalent: as you
only support options in the table, you could use the count of items in
that table, instead of 256.

See my review of v2 1/2 of the DHCPv6 series for one way to do that.

-- 
Stefano

    

Stefano Brivio