Another cppcheck version, another batch of false positives :(. These appears to be cppcheck regressions, I've filed two bugs on their tracker. Still, here are workarounds in the passt code. At least I managed to make a few genuine if minor improvements to the code along the way. David Gibson (5): cppcheck: Remove unused CPPCHECK_6936 cppcheck: Add workaround for cppcheck bug 14847 tcp: Merge common sequence logic from tcp_{buf,vu}_data_from_sock() tcp: Avoid SEQ_*() comparisons against 0 tcp: MAX_WINDOW should be unsigned Makefile | 3 +-- tcp.c | 50 +++++++++++++++++++++++++++++++++++--------------- tcp_buf.c | 28 ++++------------------------ tcp_buf.h | 3 ++- tcp_internal.h | 4 ++-- tcp_vu.c | 27 ++++----------------------- tcp_vu.h | 3 ++- util.c | 6 ++++-- 8 files changed, 54 insertions(+), 70 deletions(-) -- 2.54.0