As discussed on our recent call, I was looking again at bug 167. I discovered it's still fairly fiddly to address this, but while investigating spotted a number of cleanups to make in the vicinity. I think they make sense even without fixing bug 167 (yet), so here they are. Tested on top of my recent cppcheck series, but I don't think they conflict. v2: * Fixed some cppcheck warnings I missed initially David Gibson (4): flow: Correct misleading signature of flowside_sock_l4() Makefile: Remove unused DUAL_STACK_SOCKETS define fwd, pif: Remove duplicated logic between tcp_listen() and udp_listen() pif, util: Move listen(2) call from sock_l4_() to pif_listen() Makefile | 5 ----- flow.c | 11 +++++------ flow.h | 2 +- fwd.c | 8 +------- pif.c | 41 +++++++++++++++++++++++++++++++++++------ pif.h | 2 +- tcp.c | 38 -------------------------------------- tcp.h | 2 -- udp.c | 38 -------------------------------------- udp.h | 2 -- util.c | 7 ------- 11 files changed, 43 insertions(+), 113 deletions(-) -- 2.54.0