This obvious include was omitted, which means that declarations in the header weren't checked against definitions in the .c file. This shows up an old declaration for a function that is now static, and a duplicate #define. Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- tcp_splice.c | 2 +- tcp_splice.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tcp_splice.c b/tcp_splice.c index 99c5fa7..3c5c111 100644 --- a/tcp_splice.c +++ b/tcp_splice.c @@ -49,9 +49,9 @@ #include "util.h" #include "passt.h" #include "log.h" +#include "tcp_splice.h" #define MAX_PIPE_SIZE (8UL * 1024 * 1024) -#define TCP_SPLICE_MAX_CONNS (128 * 1024) #define TCP_SPLICE_PIPE_POOL_SIZE 16 #define TCP_SPLICE_CONN_PRESSURE 30 /* % of splice_conn_count */ #define TCP_SPLICE_FILE_PRESSURE 30 /* % of c->nofile */ diff --git a/tcp_splice.h b/tcp_splice.h index 63ffc68..2c4bff3 100644 --- a/tcp_splice.h +++ b/tcp_splice.h @@ -8,11 +8,8 @@ #define TCP_SPLICE_MAX_CONNS (128 * 1024) -struct tcp_splice_conn; - void tcp_sock_handler_splice(struct ctx *c, union epoll_ref ref, uint32_t events); -void tcp_splice_destroy(struct ctx *c, struct tcp_splice_conn *conn); void tcp_splice_init(struct ctx *c); void tcp_splice_timer(struct ctx *c); void tcp_splice_defer_handler(struct ctx *c); -- 2.38.1