Most of these are formal issues with no actual effect, some are false positives, but it looks sensible to fix all of them and there's also an interesting finding in udp_timer(). Stefano Brivio (16): treewide: Invalid type in argument to printf format specifier, CWE-686 passt: Ignoring number of bytes read, CWE-252 tcp: False "Untrusted loop bound" positive, CWE-606 treewide: Unchecked return value from library, CWE-252 tap: Resource leak, CWE-404 conf, packet: Operands don't affect result, CWE-569 passt: Improper use of negative value (CWE-394) treewide: Argument cannot be negative, CWE-687 conf: False "Assign instead of compare" positive, CWE-481 conf, tap: False "Buffer not null terminated" positives, CWE-170 tcp: Dereference null return value, CWE-476 tcp_splice: Logically dead code, CWE-561 tcp, tcp_splice: False "Negative array index read" positives, CWE-129 tcp: False "Out-of-bounds read" positive, CWE-125 udp: Out-of-bounds read, CWE-125 in udp_timer() arch: Pointer to local outside scope, CWE-562 arch.c | 10 +++--- conf.c | 15 +++++---- icmp.c | 13 +++++--- netlink.c | 40 ++++++++++++++--------- packet.c | 8 ++--- passt.c | 24 ++++++++++---- pasta.c | 25 +++++---------- pcap.c | 6 ++-- qrap.c | 15 ++++++--- tap.c | 35 +++++++++++++------- tcp.c | 75 ++++++++++++++++++++++++++----------------- tcp_splice.c | 91 ++++++++++++++++++++++++++++++++++------------------ udp.c | 5 +-- util.c | 11 ++++--- util.h | 9 ++++++ 15 files changed, 238 insertions(+), 144 deletions(-) -- 2.35.1