On Tue, Apr 21, 2026 at 12:43:31PM +1000, David Gibson wrote:
While working on pesto, I ran into a number of awkward errors with the static checkers. This series reworks the invocation of the checkers in a way that will let us deal with that. As a bonus, it also gives us static checking for passt-repair and qrap. It also makes a few other cleanups to the Makefile that seemed natural along the way.
Sorry, realised 4/13 introduced a test failure due to a bad interaction with test/build/build.py. New spin coming shortly.
David Gibson (13): Makefile: Use make variables for static checker configuration cppcheck: Split out essential defines into a BASE_CPPFLAGS variable Makefile: Remove preprocessor flags from $(FLAGS) Makefile: Remove non-standard $(FLAGS) variable Makefile: Make conditional definition of $(BIN) clearer Makefile: Use common binary compilation rule Makefile: Remove unhelpful $(HEADERS) variable Makefile: Add header dependencies for secondary binaries Makefile: Split static checker targets passt-repair: Split out inotify handling to its own function passt-repair: Simplify construction of Unix path from inotify passt-repair: Run static checkers qrap: Run static checkers
Makefile | 106 ++++++++++++++++++------------ linux_dep.h | 2 +- passt-repair.c | 171 +++++++++++++++++++++++++++---------------------- qrap.c | 42 +++++++----- 4 files changed, 188 insertions(+), 133 deletions(-)
-- 2.53.0
-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson