17 Jul
2026
17 Jul
'26
7:18 p.m.
On Fri, 17 Jul 2026 02:21:21 +0900
Hayato Kiwata
On Linux, EAGAIN and EWOULDBLOCK have the same value. Commit d2a1dc744b10 ("tap: Restructure in tap_pasta_input()") added a check for EWOULDBLOCK on purpose:
- Check for EWOULDBLOCK as well as EAGAIN for the benefit of any future ports where those might not have the same value
However, the condition uses && instead of ||, so it can never be true on a platform where EAGAIN and EWOULDBLOCK are different.
Use || instead so that the check works as intended on such platforms.
Fixes: d2a1dc744b10 ("tap: Restructure in tap_pasta_input()")
Signed-off-by: Hayato Kiwata
Applied. Thanks for fixing this, and welcome to the git log! -- Stefano