On Wed, Aug 16, 2023 at 08:26:23AM +0200, Stefano Brivio wrote:
Spotted by Coverity, relatively harmless.
Fixes: e01759e2fab0 ("tap: Explicitly drop IPv4 fragments, and give a
warning")
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>
---
tap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tap.c b/tap.c
index a6f8692..760deb7 100644
--- a/tap.c
+++ b/tap.c
@@ -561,7 +561,8 @@ static bool tap4_is_fragment(const struct iphdr *iph,
num_dropped++;
if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) {
- warn("Can't process IPv4 fragments (%lu dropped)", num_dropped);
+ warn("Can't process IPv4 fragments (%u dropped)",
+ num_dropped);
last_message = now->tv_sec;
num_dropped = 0;
}
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson