[PATCH] Fix build when HAS_GETRANDOM is undefined
e.g.
util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'?
1163 | ret = read(dev_random, (char *)buf + random_read,
Signed-off-by: Peter Foley
On Mon, Feb 23, 2026 at 12:27:39PM -0500, Peter Foley wrote:
e.g. util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'? 1163 | ret = read(dev_random, (char *)buf + random_read,
Signed-off-by: Peter Foley
Oops, that's mildly embarrassing.
Reviewed-by: David Gibson
--- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util.c b/util.c index db27431..a4f2be4 100644 --- a/util.c +++ b/util.c @@ -1160,7 +1160,7 @@ void raw_random(void *buf, size_t buflen) ret = getrandom((char *)buf + random_read, buflen - random_read, GRND_RANDOM); #else - ret = read(dev_random, (char *)buf + random_read, + ret = read(fd, (char *)buf + random_read, buflen - random_read); #endif
@@ -1177,7 +1177,7 @@ void raw_random(void *buf, size_t buflen) }
#ifndef HAS_GETRANDOM - close(dev_random); + close(fd); #endif
if (random_read < buflen) -- 2.53.0.371.g1d285c8824-goog
-- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson
On 2/23/26 18:27, Peter Foley wrote:
e.g. util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'? 1163 | ret = read(dev_random, (char *)buf + random_read,
Signed-off-by: Peter Foley
--- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util.c b/util.c index db27431..a4f2be4 100644 --- a/util.c +++ b/util.c @@ -1160,7 +1160,7 @@ void raw_random(void *buf, size_t buflen) ret = getrandom((char *)buf + random_read, buflen - random_read, GRND_RANDOM); #else - ret = read(dev_random, (char *)buf + random_read, + ret = read(fd, (char *)buf + random_read, buflen - random_read); #endif
@@ -1177,7 +1177,7 @@ void raw_random(void *buf, size_t buflen) }
#ifndef HAS_GETRANDOM - close(dev_random); + close(fd); #endif
if (random_read < buflen)
Fixes: 71d5deed5eed ("util: Add general low-level random bytes helper")
Reviewed-by: Laurent Vivier
On Mon, 23 Feb 2026 12:27:39 -0500
Peter Foley
e.g. util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'? 1163 | ret = read(dev_random, (char *)buf + random_read,
Signed-off-by: Peter Foley
Applied, thanks for fixing this, and welcome to the git log! -- Stefano
participants (4)
-
David Gibson
-
Laurent Vivier
-
Peter Foley
-
Stefano Brivio