On 8/21/26 07:04, David Gibson wrote:

It rarely matters, since we usually have getrandom(), but in case we don't our open() of /dev/random was missing O_CLOEXEC, which can cause clang warnings.

Signed-off-by: David Gibson --- util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util.c b/util.c index 500e8f55..df972a05 100644 --- a/util.c +++ b/util.c @@ -964,7 +964,7 @@ void raw_random(void *buf, size_t buflen) { size_t random_read = 0; #ifndef HAS_GETRANDOM - int fd = open(DEV_RANDOM, O_RDONLY); + int fd = open(DEV_RANDOM, O_RDONLY | O_CLOEXEC);

if (fd < 0) die_perror("Couldn't open %s", DEV_RANDOM);

Reviewed-by: Laurent Vivier