On Tue, Feb 14, 2023 at 05:30:05PM +0100, Stefano Brivio wrote:

From: Florian Weimer

Future compilers will not support implicit ints by default, causing the probe to always fail.

Link: https://bugs.passt.top/show_bug.cgi?id=42 Signed-off-by: Stefano Brivio

Reviewed-by: David Gibson

--- I'm just posting Florian's patch here for ease of review -- I just applied this by the way. Thanks Florian for the report and for the patch!

Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile index dd222a8..080c748 100644 --- a/Makefile +++ b/Makefile @@ -101,7 +101,7 @@ ifeq ($(shell :|$(CC) -fstack-protector-strong -S -xc - -o - >/dev/null 2>&1; ec FLAGS += -fstack-protector-strong endif

-C := \#define _GNU_SOURCE\n\#include \nx = FALLOC_FL_COLLAPSE_RANGE; +C := \#define _GNU_SOURCE\n\#include \nint x = FALLOC_FL_COLLAPSE_RANGE; ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; echo $$?),0) EXTRA_SYSCALLS += fallocate endif

-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson