[PATCH v3] tcp: Limit fast retransmit to one per loss event
Every duplicate ACK unconditionally triggered a fast retransmit,
even when the ACK sequence hadn't advanced.
Guard fast retransmit on !conn->retries, and increment retries
after the first retransmit. This is a quick fix to stop the
amplification storm. Full compliance with RFC 5681 Section 3.2
(three duplicate ACKs) is left to a later patch.
Link: https://bugs.passt.top/show_bug.cgi?id=224
Signed-off-by: Anshu Kumari
On 2026-11-20 12:37, Anshu Kumari wrote:
Every duplicate ACK unconditionally triggered a fast retransmit, even when the ACK sequence hadn't advanced.
Guard fast retransmit on !conn->retries, and increment retries after the first retransmit. This is a quick fix to stop the amplification storm. Full compliance with RFC 5681 Section 3.2 (three duplicate ACKs) is left to a later patch.
Link: https://bugs.passt.top/show_bug.cgi?id=224 Signed-off-by: Anshu Kumari
--- tcp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tcp.c b/tcp.c index 95f4f3e1..d3d65f76 100644 --- a/tcp.c +++ b/tcp.c @@ -2082,7 +2082,9 @@ static int tcp_data_from_tap(const struct ctx *c, struct tcp_tap_conn *conn,
tcp_tap_window_update(c, conn, max_ack_seq_wnd, now);
- if (retr) { + if (retr && !conn->retries) { + conn->retries++; + flow_trace(conn, "fast re-transmit, ACK: %u, previous sequence: %u", conn->seq_ack_from_tap, conn->seq_to_tap); @@ -2443,7 +2445,9 @@ int tcp_tap_handler(const struct ctx *c, uint8_t pif, sa_family_t af, tcp_update_seqack_from_tap(c, conn, ntohl(th->ack_seq), now);
- if (retr) { + if (retr && !conn->retries) { + conn->retries++; + flow_trace(conn, "fast re-transmit, ACK: %u, previous sequence: %u", ntohl(th->ack_seq), conn->seq_to_tap);
This looks correct to me, and matches what Stefano suggested for v2.
Two minor things:
- Missing changelog for v3 below the '---' line.
- In the TAP_FIN_RCVD path, tcp_data_from_sock() is still called if
'retr' is set but we skip the retransmission because conn->retries
is non-zero. It's probably harmless (no rewind, so we just send
what the window allows), but it might be cleaner to fold the
!conn->retries check into 'retr' there, so that both uses agree.
It might also be worth mentioning in the commit message that, as we
now account a fast retransmit in conn->retries, the next RTO is
doubled (tcp_timer_ctl() uses it as backoff exponent), and the
retransmission counts towards TCP_MAX_RETRIES.
With or without those changes:
Reviewed-by: Jon Maloy
On Fri, 20 Nov 2026 23:07:56 +0530
Anshu Kumari
Every duplicate ACK unconditionally triggered a fast retransmit, even when the ACK sequence hadn't advanced.
Guard fast retransmit on !conn->retries, and increment retries after the first retransmit. This is a quick fix to stop the amplification storm. Full compliance with RFC 5681 Section 3.2 (three duplicate ACKs) is left to a later patch.
Ada, would you have a chance to try this patch out? Would you like to be credited with a Reported-by: tag? -- Stefano
participants (3)
-
Anshu Kumari
-
Jon Maloy
-
Stefano Brivio