[PATCH v2] build: Fix errors of TCP_REPAIR_* undeclared
Based on an original patch by Dongsheng, fix the following errors on systems with glibc < 2.29:
tcp.c: In function ‘tcp_flow_repair_on’:
tcp.c:2787:38: error: ‘TCP_REPAIR_ON’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’?
if ((rc = repair_set(c, conn->sock, TCP_REPAIR_ON)))
^~~~~~~~~~~~~
TCP_REPAIR
tcp.c:2787:38: note: each undeclared identifier is reported only once for each function it appears in
tcp.c: In function ‘tcp_flow_repair_off’:
tcp.c:2807:38: error: ‘TCP_REPAIR_OFF’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’?
if ((rc = repair_set(c, conn->sock, TCP_REPAIR_OFF)))
^~~~~~~~~~~~~~
TCP_REPAIR
make: *** [Makefile:94: passt] Error 1
Link: https://bugs.passt.top/show_bug.cgi?id=121
Reported-by: Dongsheng
On Tue, 2 Sep 2025 10:17:28 +0800
Yumei Huang
Based on an original patch by Dongsheng, fix the following errors on systems with glibc < 2.29:
tcp.c: In function ‘tcp_flow_repair_on’: tcp.c:2787:38: error: ‘TCP_REPAIR_ON’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’? if ((rc = repair_set(c, conn->sock, TCP_REPAIR_ON))) ^~~~~~~~~~~~~ TCP_REPAIR tcp.c:2787:38: note: each undeclared identifier is reported only once for each function it appears in tcp.c: In function ‘tcp_flow_repair_off’: tcp.c:2807:38: error: ‘TCP_REPAIR_OFF’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’? if ((rc = repair_set(c, conn->sock, TCP_REPAIR_OFF))) ^~~~~~~~~~~~~~ TCP_REPAIR make: *** [Makefile:94: passt] Error 1
Link: https://bugs.passt.top/show_bug.cgi?id=121 Reported-by: Dongsheng
Signed-off-by: Yumei Huang
Applied, thanks, and welcome to the git log! -- Stefano
On Wed, Sep 3, 2025 at 1:07 AM Stefano Brivio
On Tue, 2 Sep 2025 10:17:28 +0800 Yumei Huang
wrote: Based on an original patch by Dongsheng, fix the following errors on systems with glibc < 2.29:
tcp.c: In function ‘tcp_flow_repair_on’: tcp.c:2787:38: error: ‘TCP_REPAIR_ON’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’? if ((rc = repair_set(c, conn->sock, TCP_REPAIR_ON))) ^~~~~~~~~~~~~ TCP_REPAIR tcp.c:2787:38: note: each undeclared identifier is reported only once for each function it appears in tcp.c: In function ‘tcp_flow_repair_off’: tcp.c:2807:38: error: ‘TCP_REPAIR_OFF’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’? if ((rc = repair_set(c, conn->sock, TCP_REPAIR_OFF))) ^~~~~~~~~~~~~~ TCP_REPAIR make: *** [Makefile:94: passt] Error 1
Link: https://bugs.passt.top/show_bug.cgi?id=121 Reported-by: Dongsheng
Signed-off-by: Yumei Huang Applied, thanks, and welcome to the git log!
Thanks, I see it!
-- Stefano
-- Thanks, Yumei Huang
participants (2)
-
Stefano Brivio
-
Yumei Huang