From: Jon Maloy <jmaloy(a)redhat.com> When we added the SO_PEEK_OFF socket option to TCP we forgot to add it even for TCP on IPv6. We do that here. Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") Signed-off-by: Jon Maloy <jmaloy(a)redhat.com> --- net/ipv6/af_inet6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index 90d2c7e3f5e9..ba69b86f1c7d 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -708,6 +708,7 @@ const struct proto_ops inet6_stream_ops = { .splice_eof = inet_splice_eof, .sendmsg_locked = tcp_sendmsg_locked, .splice_read = tcp_splice_read, + .set_peek_off = sk_set_peek_off, .read_sock = tcp_read_sock, .read_skb = tcp_read_skb, .peek_len = tcp_peek_len, -- 2.45.2
On Sat, Jul 20, 2024 at 7:09 AM <jmaloy(a)redhat.com> wrote:From: Jon Maloy <jmaloy(a)redhat.com> When we added the SO_PEEK_OFF socket option to TCP we forgot to add it even for TCP on IPv6. We do that here. Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") Signed-off-by: Jon Maloy <jmaloy(a)redhat.com>Reviewed-by: Eric Dumazet <edumazet(a)google.com> It would be nice to add a selftest for SO_PEEK_OFF for TCP and UDP, any volunteers ? Thanks.
On Sun, Jul 21, 2024 at 11:23 PM Eric Dumazet <edumazet(a)google.com> wrote:On Sat, Jul 20, 2024 at 7:09 AM <jmaloy(a)redhat.com> wrote:If Jon doesn't have much time, I volunteer :) :p Thanks, JasonFrom: Jon Maloy <jmaloy(a)redhat.com> When we added the SO_PEEK_OFF socket option to TCP we forgot to add it even for TCP on IPv6. We do that here. Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") Signed-off-by: Jon Maloy <jmaloy(a)redhat.com>Reviewed-by: Eric Dumazet <edumazet(a)google.com> It would be nice to add a selftest for SO_PEEK_OFF for TCP and UDP, any volunteers ?
On 2024-07-21 12:13, Jason Xing wrote:On Sun, Jul 21, 2024 at 11:23 PM Eric Dumazet <edumazet(a)google.com> wrote:I have been offline for a few weeks, so I didn't see this until now. You are totally welcome ;-) ///jonOn Sat, Jul 20, 2024 at 7:09 AM <jmaloy(a)redhat.com> wrote:If Jon doesn't have much time, I volunteer :) :p Thanks, JasonFrom: Jon Maloy <jmaloy(a)redhat.com> When we added the SO_PEEK_OFF socket option to TCP we forgot to add it even for TCP on IPv6. We do that here. Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") Signed-off-by: Jon Maloy <jmaloy(a)redhat.com>Reviewed-by: Eric Dumazet <edumazet(a)google.com> It would be nice to add a selftest for SO_PEEK_OFF for TCP and UDP, any volunteers ?
On Sat, 20 Jul 2024 10:09:14 -0400 jmaloy(a)redhat.com wrote:Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option") Signed-off-by: Jon Maloy <jmaloy(a)redhat.com>Please repost with the selftest and the empty line between Fixes and S-o-b removed. -- pw-bot: cr