Re: [PATCH] qrap: Pass PCI device numbers to qemu in base 10, not in base 16

On Wed, 22 Feb 2023 04:47:32 -0800
Andrea Bolognani <abologna(a)redhat.com> wrote:

...
  On Wed, Feb 22, 2023 at 11:45:08AM +0100, Stefano
Brivio wrote:
  On Wed, 22 Feb 2023 02:40:32 -0800 Andrea
Bolognani <abologna(a)redhat.com> wrote:  
  What I think needs to happen, is that each
pci_dev should contain a
 base value (16 for i440fx and 10 for q35), which is used both in the
 strtol() call used to parse the command line produced by libvirt and
 to decide whether %x or %i should be used with snprintf() to generate
 qrap's own arguments.   
 Right, I think it makes sense. Will you prepare a patch in this sense
 or should I try?   
 
 Sure, I can give it a shot. It might take a bit, because the code is
 kinda tricky and there is no test suite (that I'm aware of?) for this
 part. 
Thanks!

Right, sorry, no tests covering qrap at the moment, and the code is
horrible. The KubeVirt integration might help if you have an environment
ready.

-- 
Stefano