On Fri, May 20, 2022 at 11:01:11AM +0200, Stefano
Brivio wrote:
gcc 12.1.x (e.g. current OpenSUSE Tumbleweed,
x86_64 only,
gcc-12-1.4.x86_64) reports:
tcp.c: In function ‘tcp_send_flag’:
tcp.c:1014:9: warning: writing 16 bytes into a region of size 0 [-Wstringop-overflow=]
1014 | memcpy(low_rtt_dst + hole++, &conn->a.a6, sizeof(conn->a.a6));
| ^
tcp.c:559:24: note: at offset -16 into destination object ‘low_rtt_dst’ of size 128
559 | static struct in6_addr low_rtt_dst[LOW_RTT_TABLE_SIZE];
|
but 'hole' can't be -1, because the low_rtt_dst table is guaranteed
to have a hole: if we happened to write to the last entry, we'll go
back to index 0 and clear that one.
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>
Thanks for the reviews! I pushed those two changes already on Friday,
as they were both rather simple and blocking continuous integration.
I guess it might make sense to set up Patchwork eventually, but it
feels a bit overkill for the moment...
--
Stefano