Re: [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures

On Fri, Nov 25, 2022 at 03:01:21AM +0100, Stefano Brivio wrote:

On Thu, 24 Nov 2022 19:54:17 +1100 David Gibson wrote:

...

It turns out a couple of places on the IPv4 specific inbound path accidentally use control structures that are supposed to be for IPv6. That could lead to weird behaviour in a rather complex set of circumstances.

Whoops, this is embarrassing.

Heh, been there.

...

Path 1/4 here is the actual fix, the rest makes some clean ups to the code that should make similar mistakes harder errors harder to commit in future.

The whole series looks good to me.

...

This is based on my earlier cleanup of the UDP splicing code, although I think it will rebase trivially.

I tried, it does, but I wouldn't needlessly rebase that one on top of this, I'd rather wait a bit and apply them in order.

Ok. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson