Re: [PATCH] tcp: remove useless assignment

On Wed, 29 Nov 2023 13:34:32 +1100
David Gibson <david(a)gibson.dropbear.id.au> wrote:

...
  On Tue, Nov 28, 2023 at 05:54:23PM +0100, Laurent
Vivier wrote:
  In tcp_send_flag(), a4826ee04b76 has replaced:
 
     th->doff = sizeof(*th) / 4;
     th->doff += OPT_MSS_LEN / 4;
     th->doff += (1 + OPT_WS_LEN) / 4;
 
 by
 
     optlen = OPT_MSS_LEN + 1 + OPT_WS_LEN;
     th->doff = (sizeof(*th) + optlen) / 4;
 
 but forgot to remove the useless "th->doff += (1 + OPT_WS_LEN) / 4;"
 
 Fixes: a4826ee04b76 ("tcp: Defer and coalesce all segments with no data (flags) to
handler")
 Cc: sbrivio(a)redhat.com
 Signed-off-by: Laurent Vivier <lvivier(a)redhat.com>   
 
 Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au> 
Applied.

-- 
Stefano