Re: [PATCH 20/24] vhost-user: add vhost-user

On Mon, 12 Feb 2024 13:47:15 +1100 David Gibson wrote:

On Mon, Feb 12, 2024 at 12:19:22AM +0100, Stefano Brivio wrote:

...

On Wed, 7 Feb 2024 13:40:33 +1100 David Gibson wrote:

...

On Fri, Feb 02, 2024 at 03:11:47PM +0100, Laurent Vivier wrote:

...

add virtio and vhost-user functions to connect with QEMU.

$ ./passt --vhost-user

and

# qemu-system-x86_64 ... -m 4G \ -object memory-backend-memfd,id=memfd0,share=on,size=4G \ -numa node,memdev=memfd0 \ -chardev socket,id=chr0,path=/tmp/passt_1.socket \

I think it would be wise to use different default socket names for vhost-user than for the qemu socket protocol.

I'm not sure if there's an obvious benefit (mix them up, and nothing will work anyway). On the other hand, that means more typing and remembering what's the separator between "passt", "vhost", and "user".

...

Or even to require --socket-path: the reasons we have these rather weird default probed paths don't apply here, AFAICT.

Why not, actually? With probed paths, you can still reasonably start passt by *typing* its command line. I do it all the time, and I think it's quite nice to have.

Uh.. I'm not sure how this would change that.

Because one would have to type: ./passt --vhost-user --socket-path /tmp/passt.something instead of ./passt --vhost-user? Sure, sometimes I call my sockets /tmp/s, but still that doubles the length of the command line. -- Stefano