Re: [libvirt PATCH 1/9] conf: rename virDomainNetBackend* to virDomainNetDriver*

On a Sunday in 2023, Laine Stump wrote:
...
 This fits better with the element containing the value
(<driver>), and
allows us to use virDomainNetBackend* for things in the <backend>
element.

Signed-off-by: Laine Stump &lt;laine(a)redhat.com&gt;
---
 src/conf/domain_conf.c        |  8 ++++----
 src/conf/domain_conf.h        | 14 +++++++-------
 src/qemu/qemu_interface.c     |  8 ++++----
 src/security/virt-aa-helper.c |  2 +-
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index c19dfc5470..61d2ee819b 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -975,12 +975,12 @@ typedef enum {

 /* the backend driver used for virtio interfaces */
 typedef enum {
-    VIR_DOMAIN_NET_BACKEND_TYPE_DEFAULT = 0, /* prefer kernel, fall back to user */
-    VIR_DOMAIN_NET_BACKEND_TYPE_QEMU,    /* userland */
-    VIR_DOMAIN_NET_BACKEND_TYPE_VHOST,   /* kernel */
+    VIR_DOMAIN_NET_DRIVER_TYPE_DEFAULT = 0, /* prefer kernel, fall back to user */
+    VIR_DOMAIN_NET_DRIVER_TYPE_QEMU,    /* userland */
+    VIR_DOMAIN_NET_DRIVER_TYPE_VHOST,   /* kernel */

-    VIR_DOMAIN_NET_BACKEND_TYPE_LAST
-} virDomainNetBackendType;
+    VIR_DOMAIN_NET_DRIVER_TYPE_LAST
+} virDomainNetDriverType;

 /* the TX algorithm used for virtio interfaces */
 typedef enum {
@@ -1062,7 +1062,7 @@ struct _virDomainNetDef {
     char *modelstr;
     union {
         struct {
-            virDomainNetBackendType name; /* which driver backend to use */
+            virDomainNetDriverType name; /* which driver backend to use */ 
I recommend geting rid of the mention of 'backend' by dropping the
useless comment.

...
              virDomainNetVirtioTxModeType txmode;
             virTristateSwitch ioeventfd;
             virTristateSwitch event_idx; 
Reviewed-by: Ján Tomko &lt;jtomko(a)redhat.com&gt;

Jano