Hi Andrea, On Thu, 20 Oct 2022 11:04:19 +0200 Andrea Bolognani <abologna(a)redhat.com> wrote:Starting with version 8.1.0, libvirt uses JSON syntax when generating the arguments to -device, so they will now look like {"driver":"virtio-scsi-pci","bus":"pci.3","addr":"0x0"} instead of virtio-scsi-pci,bus=pci.3,addr=0x0 qrap needs to parse these arguments and extract the bus number in order to figure out what address to use for the virtio-net device it adds, and the libvirt change described above has broken this parsing logic. Tweak the code so that both styles are accepted and handled correctly. Note that, when JSON is in use, qrap needs to generate its own command line options in that format as well or things will not work as expected. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>Thanks for the patch, and welcome to the git log! For context, qrap will finally become useless once this patchset by Laurent: https://patchew.org/QEMU/20221021090922.170074-1-lvivier@redhat.com/ lands in qemu -- that should happen soon. However, we'll need to keep it around for a little longer, until an updated version of qemu reaches distributions, and, after that, still give a bit of time to users, so this is absolutely useful and appreciated. I just applied it. -- Stefano