Re: [PATCH v8 5/5] test: Explicit specify forwarding ports for pasta in log rotation tests

On Fri, Sep 05, 2025 at 01:03:40PM +0200, Stefano Brivio wrote:

On Fri, 5 Sep 2025 16:43:17 +1000 David Gibson wrote:

...

test/pasta_options/log_to_file uses tcp_crr in a loop to generate log messages for what it's actually testing. For this to work, pasta needs to forward two ports. We set a PORTS variable with the options for this, but never actually use it. The test works, because without the options we use automatic port forwarding.

Oops.

...

That makes the test more fragile than it needs to be, in a way that's not at all related to what we're actually trying to test. Avoid this possible point of failure by explicitly specifying the forwarding.

I encountered this because Fedora has now updated to a kernel with the /proc/net lseek() bug.

By the way, the fix is now in mainline as 2ce3d282bd50 ("proc: fix missing pde_set_flags() for net proc files"). I hoped the breakage would never reach distributions but I guess the timing was unlucky enough.

Apparently so. Oh well, good to know the fix is upstream. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson