Re: [PATCH v2 3/4] test: Parameterize run time for throughput performance tests

On Tue, Sep 06, 2022 at 06:22:42PM +0200, Stefano Brivio wrote:

On Fri, 2 Sep 2022 12:04:33 +1000 David Gibson wrote:

...

Currently all the throughput tests are run for 30s. This is reflected in both the actual parameters given to the iperf commands, but also in the matching sleeps in test_iperf3.

Allow this to be adjusted more easily with a new parameter to test_iperf3.

Signed-off-by: David Gibson --- test/lib/test | 9 +++++---- test/perf/passt_tcp | 44 +++++++++++++++++++++++--------------------- test/perf/passt_udp | 43 ++++++++++++++++++++++--------------------- test/perf/pasta_tcp | 42 ++++++++++++++++++++++-------------------- test/perf/pasta_udp | 43 ++++++++++++++++++++++--------------------- 5 files changed, 94 insertions(+), 87 deletions(-)

diff --git a/test/lib/test b/test/lib/test index 600399b..8eb1ee5 100755 --- a/test/lib/test +++ b/test/lib/test @@ -28,6 +28,7 @@ test_iperf3() { __dest="${1}"; shift __port="${1}"; shift __procs="$((${1} - 1))"; shift + __time="${1}"; shift

I'm adding, on merge, this line:

# $7: Run time, in seconds

to the comment above.

Oops, thanks. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson