On Wed, 14 Aug 2024 20:03:33 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:Using a zero port on TCP or UDP is dubious, and we can't really deal with forwarding such a flow within the constraints of the socket API. Hence we ASSERT()ed that we had non-zero ports in flow_hash(). The intention was to make sure that the protocol code sanitizes such ports before completing a flow entry. Unfortunately, flow_hash() is also called on new packets to see if they have an existing flow, so the unsanitized guest packet can crash passt with the assert. Correct this by moving the assert from flow_hash() to flow_sidx_hash() which is only used on entries already in the table, not on unsanitized data. Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>Applied, with: Reported-by: Matt Hamilton <matt(a)thmail.io> -- Stefano