On Tue, 1 Aug 2023 13:36:44 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:As discussed on our recent calls, the C11 standard introduces anonymous structure and union members and static assertions, amongst other things. Both of these could be useful in a few places in passt/pasta to make the code more readable and safer. However, at the moment, the compiler flags we use only allow C99 code. This series allows C11 code, and makes some fairly obvious cleanups by using it. It would be nice to get an opinion on this reasonably quickly, because I have other patches in the works that will look different depending on whether or not they can use C11 features....then let me start with this one, as it's straightforward: I think anonymous unions and structures are great. :) The series (especially 2/3) looks good to me, I'll push it in a bit. We also need to check for issues with reasonably older gcc (perhaps those we have in the test/distro tests, at least) and clang versions, unless you already did that. -- Stefano