Re: [PATCH] test: Update lib/term for clearer output when DEBUG is enabled

On Fri, Sep 26, 2025 at 8:38 PM Stefano Brivio wrote:

On Fri, 26 Sep 2025 16:23:48 +1000 David Gibson wrote:

...

On Fri, Sep 26, 2025 at 02:15:53PM +0800, Yumei Huang wrote:

...

When running tests with DEBUG=1, we used to get some "DEBUG:DEBUG:DEBUG:" in logs, which is not very helpful for debugging.

With this patch, the log would show the steps like below:

DEBUG: g1tools ip jq dhclient socat cat DEBUG: htools ip jq DEBUG: DEBUG: set MAP_HOST4 192.0.2.1 DEBUG: set MAP_HOST6 2001:db8:9a55::1

Suggested-by: David Gibson Signed-off-by: Yumei Huang

Reviewed-by: David Gibson

Some extra background that might be useful in the commit message:

The problem here is that "${@}" is magic and expands to multiple arguments, even though it's quoted. That means instead of the whole message going into a single string, the "DEBUG:" becomes the format string and the rest goes into unused parameters.

Applied, with this addition to the commit message.

Thank you for helping merge this so quickly. I just found this patch introduced a regression issue to some tests. Will fix it with a new patch. Sorry about that.

-- Stefano

-- Thanks, Yumei Huang