25 Nov
2022
25 Nov
'22
3:01 a.m.
On Thu, 24 Nov 2022 19:54:17 +1100
David Gibson
It turns out a couple of places on the IPv4 specific inbound path accidentally use control structures that are supposed to be for IPv6. That could lead to weird behaviour in a rather complex set of circumstances.
Whoops, this is embarrassing.
Path 1/4 here is the actual fix, the rest makes some clean ups to the code that should make similar mistakes harder errors harder to commit in future.
The whole series looks good to me.
This is based on my earlier cleanup of the UDP splicing code, although I think it will rebase trivially.
I tried, it does, but I wouldn't needlessly rebase that one on top of this, I'd rather wait a bit and apply them in order. -- Stefano