On Fri, Feb 24, 2023 at 07:49:46PM +0100, Andrea Bolognani wrote:The JSON version of the template is incorrect, making qrap completely unusable when JSON arguments are used together with the pc machine type. Fixes: b944ca185587 ("qrap: Support JSON syntax for -device") Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>--- qrap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qrap.c b/qrap.c index 2443fa3..5c18cec 100644 --- a/qrap.c +++ b/qrap.c @@ -94,7 +94,7 @@ static const struct pci_dev { { "pc-", "virtio-net-pci", "bus=pci.0,addr=0x", "", - "\"bus\":\"pci.0\",\"addr=0x", "", + "\"bus\":\"pci.0\",\"addr\":\"0x", "", 2, /* 1: ISA bridge */ 31 }, {-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson