On Wed, 26 Feb 2025 17:04:19 +1100 David Gibson <david(a)gibson.dropbear.id.au> wrote:From Red Hat internal testing we've had some reports that if attempting to migrate without passt-repair, the failure mode is uglier than we'd like. The migration fails, which is somewhat expected, but we don't correctly roll things back on the source, so it breaks network there as well. Handle this more gracefully allowing the migration to proceed in this case, but allow TCP connections to break I've test patches 1..2/3 reasonably: * I get a clean migration if there are now active flows * Migration completes, although connections are broken if passt-repair isn't connected * Basic test suite (minus perf) Patch 3 I've run the basic test suite on, but haven't tested the specific functionality of. Alas, I've spent most of today battling with RHEL, virt-install, unshare and various other things trying to create a test environment simulating two hosts with (possibly) different addresses.Sorry, I've been busy with other stuff most of the day and I didn't manage to test the specific functionality of 3/3 either. :( I reviewed this and it all looks good to me but I'm not sure if I should merge this now or wait until we manage to test the 3/3 case. Let me know your preference. I can also merge up to 2/3 if it makes things more convenient. -- Stefano