Re: [RFC v2 06/11] tap: move static iov_sock to tcp_buf_data_from_sock

On Mon, Jul 28, 2025 at 06:43:50PM +0200, Eugenio Perez Martin wrote:

On Wed, Jul 23, 2025 at 9:22 AM David Gibson wrote:

...

On Wed, Jul 09, 2025 at 07:47:43PM +0200, Eugenio Pérez wrote:

...

As it is the only function using it. I'm always confusing it with tcp_l2_iov, moving it here avoids it.

Signed-off-by: Eugenio Pérez

I like making it local, I'd question whether it even needs to remain 'static'.

Probably not, I was just worried about a stack overflow. But I didn't measure its size to be honest.

I think we have comparable sized things on the stack already, such as mmsghdr[UIO_MAXIOV] in udp_tap_handler. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson