On 1/11/23 1:33 PM, Daniel P. Berrangé wrote:
On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine
Stump wrote:
+ <backend type='passt'
logFile='/var/log/loglaw.blog' upstream='eth42'/>
I don't think that 'upstream' is really describing a property of the
backend.
This is expressing a traffic routing restriction for the 'user'
networking type. IMHO it should probably be using the existing
<source dev="xxxx"/> element, that is currently used by the
'direct' networking type.
I'm still not sure *exactly* what it does; it apparently grabs the
routes that are fed to the guest from the given host interface; I should
probably ask Stefano to explain it to me again (he described it once,
but that was along with explanations of several other things).
So it's not *exactly* the same as <source dev='xxx'/> for
type='direct'
(which determines the link-level connection rather than IP routing), but
definitely very similar.
Can we see about fixing this before release.
Yes, that makes sense. I'm not sure why I didn't think of it (usually I
try *too* hard to re-use existing XML).
I'll make a patch and send it later today.