On 01/10/2024 20:22, Stefano Brivio wrote:
Run functional and performance tests for
vhost-user mode as well. For
functional tests, we add passt_vu and passt_vu_in_ns as symbolic links
to their non-vhost-user counterparts, as no differences are intended
but we want to distinguish them in test logs.
For performance tests, instead, we add separate perf/passt_vu_tcp and
perf/passt_vu_udp files, as we need longer test duration, as well as
higher UDP sending bandwidths and larger TCP windows, to actually get
the highest throughput vhost-user mode offers.
For valgrind tests, vhost-user mode needs two extra system calls:
statx and readlink. Add them as EXTRA_SYSCALLS for the valgrind
target.
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
---
v2:
- oops, add all the files I forgot in v1: test/perf/passt_vu_tcp,
test/perf/passt_vu_udp, and symbolic links
- also run the 'two_guests' case in vhost-user mode
Makefile | 3 +-
test/lib/perf_report | 15 +++
test/lib/setup | 77 ++++++++++++---
test/passt_vu | 1 +
test/passt_vu_in_ns | 1 +
test/perf/passt_vu_tcp | 211 +++++++++++++++++++++++++++++++++++++++++
test/perf/passt_vu_udp | 159 +++++++++++++++++++++++++++++++
test/run | 25 +++++
test/two_guests_vu | 1 +
9 files changed, 478 insertions(+), 15 deletions(-)
create mode 120000 test/passt_vu
create mode 120000 test/passt_vu_in_ns
create mode 100644 test/perf/passt_vu_tcp
create mode 100644 test/perf/passt_vu_udp
create mode 120000 test/two_guests_vu
Something like this is missing:
diff --git a/test/lib/setup_ugly b/test/lib/setup_ugly
index 4b2a0774de1d..46089eb9834b 100755
--- a/test/lib/setup_ugly
+++ b/test/lib/setup_ugly
@@ -33,7 +33,7 @@ setup_memory() {
pane_or_context_run guest 'qemu-system-$(uname -m)' \
' -machine accel=kvm' \
- ' -m '${VMEM}' -cpu host -smp '${VCPUS}
\
+ ' -m '$((${MEM_KIB} / 1024 / 4))' -cpu host -smp
'${VCPUS} \
Oops, right, I guess I skipped that test as well while testing this
change. Feel free to just change that in this patch if you carry it in
your series (it looks okay to me).
--
Stefano