Re: [PATCH v12 3/9] arp/ndp: send ARP announcement / unsolicited NA when neigbour entry added

Nit, in the title: neighbour. On Thu, 2 Oct 2025 20:34:06 -0400 Jon Maloy wrote:

ARP announcements and unsolicited NAs should be handled with caution because of the risk of malignant users emitting them to disturb network communication.

There is however one case we where we know it is legitimate and safe for us to send out such messages: The one time we switch from using ctx->own_tap_mac to a MAC address received via the recently added neigbour subscription function. Later changes to

...same here. Other than this, and all the pending comments (including changes to consistently represent guest-side link-layer addresses), and the remaining part of 2/9, the rest looks good to me. -- Stefano