[PATCH v2 10/12] icmp: Warn on receive errors from ping sockets

Currently we silently ignore an errors receiving a packet from a ping socket. We don't expect that to happen, so it's probably worth reporting if it does. Signed-off-by: David Gibson --- icmp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/icmp.c b/icmp.c index b26c61f..7e698f3 100644 --- a/icmp.c +++ b/icmp.c @@ -81,8 +81,11 @@ void icmp_sock_handler(const struct ctx *c, int af, union epoll_ref ref) return; n = recvfrom(ref.fd, buf, sizeof(buf), 0, &sr.sa, &sl); - if (n < 0) + if (n < 0) { + warn("%s: recvfrom() error on ping socket: %s", + pname, strerror(errno)); return; + } if (af == AF_INET) { struct icmphdr *ih4 = (struct icmphdr *)buf; -- 2.43.0