Re: [PATCH] Introduce passt-repair

On Tue, Feb 04, 2025 at 01:05:14AM +0100, Stefano Brivio wrote:

A privileged helper to set/clear TCP_REPAIR on sockets on behalf of passt. Not used yet.

Signed-off-by: Stefano Brivio --- Note: I'm merging this right now, but posting anyway to ease review.

[snip]

+/** + * main() - Entry point and whole program with loop + * @argc: Argument count, must be 2 + * @argv: Argument: path of UNIX domain socket to connect to + * + * Return: 0 on success (EOF), 1 on error, 2 on usage error + * + * #syscalls:repair connect setsockopt write exit_group + * #syscalls:repair socket s390x:socketcall i686:socketcall + * #syscalls:repair recvfrom recvmsg arm:recv ppc64le:recv + * #syscalls:repair sendto sendmsg arm:send ppc64le:send + */

You are missing close() :(. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson