On Fri, Sep 02, 2022 at 05:38:41PM +0200, Stefano
Brivio wrote:
fedora-review says:
Note: No known owner of /usr/share/selinux/packages/passt,
/usr/share/doc/passt
Reported-by: Daniel P. Berrangé <berrange(a)redhat.com>
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
---
contrib/fedora/passt.spec | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
index 922f584..1e328e2 100644
--- a/contrib/fedora/passt.spec
+++ b/contrib/fedora/passt.spec
@@ -49,7 +49,7 @@ This package adds SELinux enforcement to passt(1) and pasta(1).
%make_build
%install
-%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir}
docdir=%{_docdir}/passt
+%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir}
docdir=%{_docdir}/%{name}
%ifarch x86_64
ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/passt.avx2.1
ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pasta.avx2.1
@@ -70,6 +70,8 @@ semodule -r passt 2>/dev/null || :
semodule -r pasta 2>/dev/null || :
%files
+%dir %{_datadir}/selinux/packages/%{name}
This needs to be in the -selinux package %files list
+%dir
%{_docdir}/%{name}
If you're going to use %{name} here...
%license
LICENSES/{AGPL-3.0-or-later.txt,BSD-3-Clause.txt}
I'd suggest keeping this as the first item in %files
Moved it back.
%doc
%{_docdir}/passt/README.md
%doc %{_docdir}/passt/demo.sh
..then be consistent here too
Right, I missed those.
--
Stefano