Extract buffers management code from tcp.c and move it to tcp_buf.c tcp.c keeps all the generic code and will be also used by the vhost-user functions. Also compare mode to MODE_PASTA, as we will manage vhost-user mode (MODE_VU) like MODE_PASST. v7: - update comments (tap_flush_pools(), func and line) - drop "-L4" in tcp_buf.c header - fix *optlen initializatio - fix tcp4_flags_used/tcp6_flags_used value on error - fix seq_to_tap value v6: - reorder declarations, align summing, add curly brackets - rename tap_handler_all() to tap_handler() - rename packet_add_all_do() to tap_add_packet and remove func and line. - rename pool_flush_all() to tap_flush_pools() - rename tcp_fill_flag_header() to tcp_prepare_flags() - set optlen to 0 in tcp_prepare_flags() v5: - remove: [PATCH v4 01/10] tcp: inline tcp_l2_buf_fill_headers() - merge [PATCH v4 09/10] tcp: remove tap_hdr parameter into tcp: extract buffer management from tcp_send_flag() - update comments v4: - remove "tcp: extract buffer management from tcp_conn_tap_mss()" as the MSS size can be the same between socket and vhost-user. - rename tcp_send_flag() and tcp_data_from_sock() to tcp_buf_send_flag() and tcp_buf_data_from_sock() v3: - add 3 new patches tap: use in->buf_size rather than sizeof(pkt_buf) tcp: remove tap_hdr parameter iov: remove iov_copy() v2: - compare to MODE_PASTA in conf_open_files() too - move taph out of udp_update_hdr4()/udp_update_hdr6() Laurent Vivier (8): tcp: extract buffer management from tcp_send_flag() tcp: move buffers management functions to their own file tap: refactor packets handling functions udp: refactor UDP header update functions udp: rename udp_sock_handler() to udp_buf_sock_handler() vhost-user: compare mode MODE_PASTA and not MODE_PASST iov: remove iov_copy() tap: use in->buf_size rather than sizeof(pkt_buf) Makefile | 5 +- conf.c | 14 +- iov.c | 39 ---- iov.h | 3 - isolation.c | 10 +- passt.c | 4 +- tap.c | 132 ++++++----- tap.h | 3 + tcp.c | 580 ++++--------------------------------------------- tcp_buf.c | 519 +++++++++++++++++++++++++++++++++++++++++++ tcp_buf.h | 16 ++ tcp_internal.h | 96 ++++++++ udp.c | 68 +++--- udp.h | 2 +- 14 files changed, 803 insertions(+), 688 deletions(-) create mode 100644 tcp_buf.c create mode 100644 tcp_buf.h create mode 100644 tcp_internal.h -- 2.45.2