Re: [PATCH 25/28] cppcheck: Remove unused objectIndex suppressions

On Wed, Sep 28, 2022 at 10:58:29PM +0200, Stefano Brivio wrote: 11;rgb:ffff/ffff/ffff> On Wed, 28 Sep 2022 14:33:36 +1000

David Gibson wrote:

...

I can't get these warnings to trigger on the cppcheck versions I have, so remove them. If we find in future we need to replace these, they should be replaced with inline suppressions so its clear what's the section of code at issue.

At least for TCP:

- /* First buffer is to discard data, last one may be partially filled. */ - iov[-1].iov_len = already_sent;

gone with commit 38fbfdbcb916 ("tcp: Get rid of iov with cached MSS, drop sendmmsg(), add deferred flush").

Ah, thanks, I've added that background to the commit message. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson