Re: [PATCH v3 0/6] Test and linter fixups

On Tue, Oct 07, 2025 at 04:13:46PM +0200, Stefano Brivio wrote:

On Thu, 2 Oct 2025 15:04:31 +1000 David Gibson wrote:

...

Before starting to convert testcases to use tunbridge, I wanted to add linting for the Python test scripts. While doing that I discovered a new crop of cppcheck and clang-tidy false positives, and a Makefile bug.

Here's a batch of fixes.

I didn't manage to get through the whole testsuite with this. I keep getting hangs on rampstream_out, which I *think* are unrelated.

I saw this once too, a couple of weeks ago.

Maybe it's the same issue I've been trying to find the time to work on for a while now, that is, the kernel not freezing queues of the sockets from the source instance once they switch to repair mode.

Maybe.

But it happened just once so I didn't try re-running with PCAP=1. I might, if it happens again.

...

v3: * Delete mypy's cache on make clean v2: * Actually understood why exetool was being deleted, and fixed it properly.

David Gibson (6): clang-tidy: Suppress redundant expression warning cppcheck: Suppress the suppression of a suppression cppcheck: Suppress a buggy cppcheck warning cppcheck: Suppress variable scope warnings in dhcpv6() test: Don't delete exetool on make clean test: Add linting of Python test scripts

I'm applying this now, even though, strictly speaking, this breaks tests because test/README.md doesn't mention one needs to install flake8 and mypy, and I don't think they're very commonly installed, so I think you should update it.

Ah, good point. Beter yet, I should skip rather than failing if the linters aren't available. I'll send a follow up for this. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson