Re: [PATCH 2/6] test: Add linting of Python test scripts

On Wed, Oct 01, 2025 at 12:48:36PM +0200, Stefano Brivio wrote:

On Wed, 1 Oct 2025 12:40:09 +0200 Paul Holzinger wrote:

...

On 01/10/2025 12:23, Stefano Brivio wrote:

...

On Wed, 1 Oct 2025 19:51:58 +1000 David Gibson wrote:

...

We currently have one test moved to the new exeter based framwork written in Python. We plan to add many more, so add linting (flake8) and type checking (mypy) of those scripts. This can be invoked manually with "make flake8" or "make mypy" in test/, and is also added to the static checkers test set. I never used a Python linter, so I'm not sure if it's as bad as Go or Rust linters taking the whole poetry away, as it happened for instance in my most recent experience with 'cargo fmt':

https://github.com/AsahiLinux/muvm/compare/68094c02c19b6f5d5e3def6d29379c124...

https://github.com/AsahiLinux/muvm/pull/111#discussion_r1863551727 (you need to click around before you get to it, no idea how to share a proper link that opens that comment right away)

Not really on topic for this series but since you brought up rust there is actually a "#[rustfmt::skip]" attribute that can be used to skip the formatting selectively in case you need it in the future.

Ah, thanks, I didn't know about it. Now that you mention that, I just found out that, with flake8, it looks like one can ignore the entire file with "# flake8: noqa" on a line of its own:

Right. More selective suppressions are also possible. I have exactly one in exeter, for a case where I really am doing something odd for testing reasons. Fwiw, I gave up on using pylint, a different linting tool, because it whinged too much. flake8 I've been fairly happy with. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson