By the way, I won't have a chance to try this before a couple of days,
if needed, but another thought: if we end up adding/changing hundreds
of include lines as a result, maybe the cleanup David mentioned would
actually be in scope at that point, even from a mere perspective of
"noise" we would add, or effort you're spending anyway (let's make it
fully worth it I'd say).
I tried running clang-include-cleaner and then massaging it to not include c++ only headers or stuff from bits/
That wound up with:
64 files changed, 349 insertions(+), 189 deletions(-)
Unfortunatly include-cleaner isn't smart enough to handle things like #include <sys/socket.h> instead of <bits/sockaddr.h>
So absent adding pragma annotations to glibc headers, I'm not sure a clean clang-include-cleaner check is possible.
I can send it as a proper patch as well if you're interested, but it's a lot of churn and I'm not sure how to prevent back-sliding...