Re: [PATCH] Fix build when HAS_GETRANDOM is undefined

On 2/23/26 18:27, Peter Foley wrote:

e.g. util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'? 1163 | ret = read(dev_random, (char *)buf + random_read,

Signed-off-by: Peter Foley --- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util.c b/util.c index db27431..a4f2be4 100644 --- a/util.c +++ b/util.c @@ -1160,7 +1160,7 @@ void raw_random(void *buf, size_t buflen) ret = getrandom((char *)buf + random_read, buflen - random_read, GRND_RANDOM); #else - ret = read(dev_random, (char *)buf + random_read, + ret = read(fd, (char *)buf + random_read, buflen - random_read); #endif

@@ -1177,7 +1177,7 @@ void raw_random(void *buf, size_t buflen) }

#ifndef HAS_GETRANDOM - close(dev_random); + close(fd); #endif

if (random_read < buflen)

Fixes: 71d5deed5eed ("util: Add general low-level random bytes helper") Reviewed-by: Laurent Vivier