On Sat, Sep 10, 2022 at 10:41:19PM +0200, Stefano Brivio wrote:On Sat, 10 Sep 2022 17:45:48 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:Huh, I completely missed that there.On Fri, Sep 09, 2022 at 05:00:35PM +0200, Stefano Brivio wrote:They are, in some sense: $ git log --oneline -1 hooks/pre-push ba72c83 hooks: Copy .webp diagram versions too I then copy that single hook to .git whenever I clone a repository, as suggested in the comment:On Fri, 9 Sep 2022 13:30:28 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:Uh.. right. The hooks aren't part of the repo contents, though, so I can't change that.The asciinema video handling creates a number of temporary files (.uncat, .start, .stop) which currently go into the source tree. Put them in the temporary state directory to avoid clutter. Put the final processed video into the test_logs/ directory, since it's essentially a test output artefact.This needs an update in hooks/pre-push in any case, but... I wouldn't$ grep .git hooks/pre-push # cp hooks/pre-push .git/hooks/pre-push ...this should eventually become a server-side post-receive hook, I guess, using a temporary branch for testing and then forwarding the updates to master if the tests pass.Right. It wouldn't make sense for me or anyone else to have this as a pre-push hook.But I haven't looked yet into headless asciinema captures -- I guess it's doable and I've been doing something similar with Xvfb, it might need some extra setup in the test scripts though.Right. It should be ok as long as $TERM and the stty settings match. Obviously a pty will have to be allocated for the command, which I suspect asciinema rec must do anyway. It might be as simple as setting the --cols and --rows options.Ok, I've done that in the next spin. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibsonHmm, yes, that would be my preferred option at the moment. I can also take care of updating the hook when I apply your patches.mix those. The current directory listing at: https://passt.top/builds/latest/test/ is sort of usable right now, and if I just scp everything into there, it wouldn't be anymore. Maybe we could move the cast files to test_logs/web/, then scp: - test_logs/* (files only) to latest/test/ - test_logs/web/* to latest/web/ instead?Sure, we could do that. It's really up to you what you want the workflow to be.